Some help

[sckatchof]

hi guys i have a small problem the script work but i have some errors :

lien 12 "getElementData

server side :

  
local vehicleMarker1 = createMarker( x, y, z, 'cylinder', 1, 255, 255, 255, 150 ) 
  
function vehicleMarkerHit ( hitElement, matchingDimension ) 
    if getElementType ( hitElement ) == "player" and not isPedInVehicle (hitElement) then 
    getElementData ( hitElement, "Job", "Taxi Driver", true ) 
        local vehicle = createVehicle ( 420, x, y, z, 0, 0, 0 ) 
        warpPedIntoVehicle(hitElement, vehicle) 
        end 
    end 
  
addEventHandler( "onMarkerHit", vehicleMarker1 , vehicleMarkerHit ) 

[X-SHADOW]

so the probelm is not set the element or the event wrong or what ?

i dont see any error with getElementData

[sckatchof]

so the probelm is not set the element or the event wrong or what ?

i dont see any error with getElementData

that is my problem ==>

WARING : Myscript.lua:12: bad argument @'getElementData' [expected bool at argument 3, got string 'Taxi Driver'

Edited March 11, 2012 by Guest

[IncreEngine]

getElementData ( hitElement, "Job", true ) 

Show your setElementData code.

[sckatchof]

getElementData ( hitElement, "Job", true ) 

Show your setElementData code.

Thanks for help but it wok for all jobs i have make many job like pilot or limo driver .

local vehicleMarker1 = createMarker( x, y, z, 'cylinder', 1, 255, 255, 255, 150 ) 
 local Taxijob = "Taxi Driver" 
  
function vehicleMarkerHit ( hitElement, matchingDimension ) 
    if getElementType ( hitElement ) == "player" and not isPedInVehicle (hitElement) then 
     getElementData ( hitElement, "Job", Taxijob, true ) 
        local vehicle = createVehicle ( 420, x, y, z, 0, 0, 0 ) 
        warpPedIntoVehicle(hitElement, vehicle) 
        end 
    end 
addEventHandler( "onMarkerHit", vehicleMarker1 , vehicleMarkerHit ) 

[drk]

LOL? So easy to see the problem. getElementData wrong arguments.

  
local vehicleMarker1 = createMarker( x, y, z, 'cylinder', 1, 255, 255, 255, 150 ) 
  
function vehicleMarkerHit ( hitElement, matchingDimension ) 
    if getElementType ( hitElement ) == "player" and not isPedInVehicle (hitElement) then 
       if ( getElementData ( hitElement, "Job" ) == "Taxi Driver" ) then -- Maybe this is what you want 
        local vehicle = createVehicle ( 420, x, y, z, 0, 0, 0 ) 
        warpPedIntoVehicle(hitElement, vehicle) 
       end 
    end 
end 
addEventHandler( "onMarkerHit", vehicleMarker1 , vehicleMarkerHit ) 

[GanJaRuleZ]

You can make like this :

  
local vehicleMarker1 = createMarker( x, y, z, 'cylinder', 1, 255, 255, 255, 150 ) 
 local Taxijob = "Taxi Driver" 
  
function vehicleMarkerHit ( hitElement, matchingDimension ) 
    if getElementType ( hitElement ) == "player" and not isPedInVehicle (hitElement) then 
       local job = getElementData ( hitElement, "Job", true ) 
        if ( job == "Taxi Driver" ) then 
        local vehicle = createVehicle ( 420, x, y, z, 0, 0, 0 ) 
        warpPedIntoVehicle(hitElement, vehicle) 
       elseif ( job == 'Limo Driver") then 
      --etc etc 
        end 
    end 
addEventHandler( "onMarkerHit", vehicleMarker1 , vehicleMarkerHit ) 
  
 

[drk]

LOL? Why create a variable with string "Taxi Driver" ? And why you need to do

       local job = getElementData ( hitElement, "Job", true ) 
        if ( job == "Taxi Driver" ) then 

Mine is better:

if ( getElementData ( hitElement, "Job", true ) == "Taxi Driver" ) then 

[GanJaRuleZ]

Actually , i copied the script , and changed just that 2 lines , but mine is better in big scaled..

Just think out : Somewhere 50 jobs , for every line do "if ( getElementData ( hitElement, "Job", true ) == "Taxi Driver"" instead of ' if ( job == "Taxi Driver" ) then" ..

Think logic.

[drk]

But why need create a variable with a string "Taxi Driver" ?

[sckatchof]

thanks guys it work

[drk]

No problem

[IncreEngine]

U're welcome.

[GanJaRuleZ]

Np , @Draken , i forgot about it