Jump to content

I need Help, this code dont work...


ColdBlood

Recommended Posts

  
function playerCarPark ( source, cmd) 
    if(isPedInVehicle(source)) then 
        local playercar = getPedOccupiedVehicle ( source ) 
        if(getElementData ( playercar, "owner" ) == getElementData ( source, "playerid" )) then 
            local x, y, z = getElementPosition ( source ) 
            local xa,ya,a = getElementRotation ( playercar ) 
            setElementData (playercar,"xpos",x) 
            setElementData (playercar,"ypos",y) 
            setElementData (playercar,"zpos",z) 
            setElementData (playercar,"angle",a) 
            outputChatBox ("You parked your car, don't forget to close it!",source, 243,149,72 ) 
            saveCars() 
        else 
            outputChatBox ("Error: It is not your car!",source, 255,255,127 ) 
        end 
   
end 
  
addCommandHandler ("carpark",playerCarPark) 
  

The script is ment to let the owner of the car park its vehicle (save its positions) but it "keeps saying this isnt your car" but when you enter is says "This is your vehicle"!

Also same problem with this one

  
function playerCarSell ( source, cmd) 
    if(isPedInVehicle(source)) then 
        local playercar = getPedOccupiedVehicle ( source ) 
        if(getElementData ( playercar, "owner" ) == getElementData ( source, "playerid" )) then 
            setElementData (playercar,"owner",0) 
            givePlayerMoney ( source, getElementData ( playercar, "price" )/100*50 ) 
            outputChatBox ("You sold your car!",source, 243,149,72 ) 
            saveCars() 
        else 
            outputChatBox ("Error: It is not your car!",source, 255,255,127 ) 
        end 
    else 
         
end 
  
addCommandHandler ("carsell",playerCarSell) 
  

Link to comment

would this had worked better?

  
function playerCarPark ( source, cmd) 
    if(isPedInVehicle(source)) then 
        local playercar = getPedOccupiedVehicle ( source ) 
end 
        if(getElementData ( playercar, "owner" ) == getElementData ( source, "playerid" )) then 
            local x, y, z = getElementPosition ( source ) 
            local xa,ya,a = getElementRotation ( playercar ) 
            setElementData (playercar,"xpos",x) 
            setElementData (playercar,"ypos",y) 
            setElementData (playercar,"zpos",z) 
            setElementData (playercar,"angle",a) 
            outputChatBox ("You parked your car, don't forget to close it!",source, 243,149,72 ) 
            saveCars() 
        else 
end 
            outputChatBox ("Error: It is not your car!",source, 255,255,127 ) 
        end 
   
end 
  
addCommandHandler ("carpark",playerCarPark) 
  

even if it did how do i stop it from the original problem ( the car saying it doesnt belong to its owner when they type the command)

Link to comment
function playerCarPark ( source, cmd) 
    if(isPedInVehicle(source)) then 
        local playercar = getPedOccupiedVehicle ( source ) 
        if(getElementData ( playercar, "owner" ) == getElementData ( source, "playerid" )) then 
            local x, y, z = getElementPosition ( source ) 
            local xa,ya,a = getElementRotation ( playercar ) 
            setElementData (playercar,"xpos",x) 
            setElementData (playercar,"ypos",y) 
            setElementData (playercar,"zpos",z) 
            setElementData (playercar,"angle",a) 
            outputChatBox ("You parked your car, don't forget to close it!",source, 243,149,72 ) 
            saveCars() 
        else 
            outputChatBox ("Error: It is not your car!",source, 255,255,127 ) 
        end 
     else 
            outputChatBox ("Error: You are not in car!",source, 255,255,127 ) 
     end 
end 
addCommandHandler ("carpark",playerCarPark) 

Link to comment

and what about this one?....

  
function playerCarSell ( source, cmd) 
    if(isPedInVehicle(source)) then 
        local playercar = getPedOccupiedVehicle ( source ) 
        if(getElementData ( playercar, "owner" ) == getElementData ( source, "playerid" )) then 
            setElementData (playercar,"owner",0) 
            givePlayerMoney ( source, getElementData ( playercar, "price" )/100*50 ) 
            outputChatBox ("You sold your car!",source, 243,149,72 ) 
            saveCars() 
        else 
            outputChatBox ("Error: It is not your car!",source, 255,255,127 ) 
        end 
    else 
        
end 
  
addCommandHandler ("carsell",playerCarSell) 
  

Link to comment

first thing you should've done is output the values you're trying to compare, because it is obvious that something is wrong there.

  
-- before 
  if (getElementData ( playercar, "owner" ) == getElementData ( source, "playerid" )) then 
-- you should do something like 
outputChatBox("Car owner value: "..tostring(getElementData ( playercar, "owner" ))..", playerid value: "..tostring(getElementData ( source, "playerid" ))) 
  

or outputDebugString if debugging is on.

see what is in those values, if they are the same (numbers? idk what playerid is), maybe one of the numbers is not a number, but a string.

Link to comment

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...