Bad argument @ 'getElementType' [Expected element at argument 1, got nil]

[DouglaS666]

function MakePlayerHeadshot( attacker, weapon, bodypart, loss )
    if getElementType ( attacker ) == "ped" then
        if bodypart == 9 then
            triggerEvent( "onPlayerHeadshot", source, attacker, weapon, loss )
            setPedHeadless ( source, true )
            killPed( source, attacker, weapon, bodypart )
            setTimer( BackUp, 900, 1, source )
        end
    end
end

function MakeHeadshot( source, attacker, weapon, loss )
    triggerEvent( "onPlayerHeadshot", source, attacker, weapon, loss )
    killPed( source, attacker, weapon, 9 )
    setPedHeadless ( source, true )
    setTimer( BackUp, 900, 1, source )
end

function BackUp( source )    
    if getElementType ( source ) == "player" then
        setPedHeadless ( source, false )
    end
end

function outputHeadshotIcon (killer, weapon, bodypart)
    if bodypart == 9 then
        cancelEvent()
        exports.killmessages:outputMessage (
        {getPlayerName(killer),{"padding",width=3},{"icon",id=weapon},{"padding",width=3},{"icon",id=256},{"padding",width=3},{"color",r=r1,g=g1,b=b1},getPlayerName(source) }, getRootElement(),r2,g2,b2)                 
    end
end
addEvent ( "onServerHeadshot", true )
addEventHandler( "onPlayerDamage", getRootElement(), MakePlayerHeadshot )
addEventHandler( "onPlayerKillMessage", getRootElement(), outputHeadshotIcon )
addEventHandler( "onServerHeadshot", getRootElement(), MakeHeadshot )

 

[WiBox]

this one; if getElementType ( attacker ) == "ped" then

or this one; if getElementType ( source ) == "player" then

[DouglaS666]

Thanks
 

Edited May 27, 2018 by DouglaS666

[IIYAMA]

1. Not error proof:

if getElementType ( attacker ) == "ped" then

 

2. More error proof:

if attacker and getElementType ( attacker ) == "ped" then

 

3. 100/100 error proof

if isElement(attacker) and getElementType ( attacker ) == "ped" then

But the function isElement isn't always needed, because sometimes MTA functions/events give you either an element back or false/nil back. Which means I would rather pick option 2, for the optimization of my code.

In some cases while using variables/elementdata to store data for later, only option 3 will work.

Yet sometimes you do not want to check for the element type, if you know what you have stored.

 

So in the end, lets strip it to the basic:

 

1. Not error proof:

--nothing

 

2. More error proof:

if element then

 

3. 100/100 error proof

if isElement(element) then